Interesting thoughts, I get where you are coming from. Redick was more efficient, but better might be a bit inaccurate. I'm assuming you mean Carter's second year because his first season there, he was certainly ending games. I can't really say I watched enough, paid attention or remember who was ending games for the 20 or so games Carter was there in his second season. I thought the trade was very pre-mature.
Of course we have to take into account that Redick has never had as high usage as Carter partially because he just can't create as many opportunities for himself as Carter without forcing up bad shots due to some physical limitations.
Carter was the teams leading per minute scorer putting up 18/5/4 on .557 TS% and had a 111 Ortg and 16.2 PEE. Redick's efficiency at .589 TS% and 117 Ortg was great and hopefully he does that here, but 14/3/2 per 36 was a decent difference from Carter.. They weren't playing the same role, Carter was doing more shot creating and facilitating and Redick couldn't replicate Carter's role and be as effective. Part of what was affecting the perception of Carter was the amount of money he was making and the expected production more so than him not being good enough.
Carter was overall more productive though, but the actual reality is that J-Rich was actually the one starting over him, and again, it does come back to size. Redick shot better and was more efficient, but per 36 it was J-Rich: 14.4 / 4.1 / 2.1 and Redick: 14.1 / 2.7 / 2.4. Both low turnover, basically the same eFG%, but Redidk was a far superior FT shooter, so that was the edge in TS%.
The Magic were a mess though, Otis was horrible. When your team is good, you have to stick with it for at least some time, you can't just keep shuffling the main pieces of roster every time there's some struggle or because you didn't win that year. One of the league's worst GM's.
Afflalo is a different case, for some reason I was thinking they had him with Dwight even though he came as part of that trade. I actually think he was just starting because Redick was actually BETTER at creating and ball handling, and he fit better leading the bench on offense than Afflalo did.
Afflalo has never really impressed with his individual scoring ability or ability to handle the ball and/or create shots.